Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cython tidying #1774

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Cython tidying #1774

wants to merge 18 commits into from

Conversation

camillescott
Copy link
Member

Cythonizes the free floating functions and cleans up some code locations.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make clean diff-cover If it introduces new functionality in
    scripts/ is it tested?
  • make format diff_pylint_report cppcheck doc pydocstyle Is it well
    formatted?
  • Did it change the command-line interface? Only backwards-compatible
    additions are allowed without a major version increment. Changing file
    formats also requires a major version number increment.
  • For substantial changes or changes to the command-line interface, is it
    documented in CHANGELOG.md? See keepachangelog
    for more details.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Do the changes respect streaming IO? (Are they
    tested for streaming IO?)

@luizirber
Copy link
Member

I don't know if you want to cover this here, but we can remove all the from __future__ and sys.version checks from the code (yay!)

@camillescott
Copy link
Member Author

camillescott commented Sep 7, 2017 via email

@camillescott
Copy link
Member Author

For @standage: a good example of how to do the new style paired read handling can be found the in sample-reads-randomly script: https://github.com/dib-lab/khmer/pull/1774/files#diff-d7ee671a9cc8a3d7f82adcc860c1850b

Basically, utility function allows handling multiple paired-end samples in either split, interleaved, or single mode seamlessly, using the new Cython-based BrokenPairedReader.

@standage
Copy link
Member

Woot! This PR is down from 140 files to 37! :-)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants