Skip to content

Field sensitivity: account for array size in all index expressions #8579

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tautschnig
Copy link
Collaborator

When code outside the core field-sensitivity implementation produces index expressions we must not blindly turn such expressions into ssa_exprt.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig added bug Kani Bugs or features of importance to Kani Rust Verifier labels Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.38%. Comparing base (5cd085b) to head (eab49c8).

Files with missing lines Patch % Lines
src/goto-symex/field_sensitivity.cpp 89.28% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8579   +/-   ##
========================================
  Coverage    80.38%   80.38%           
========================================
  Files         1688     1688           
  Lines       207183   207196   +13     
  Branches        73       73           
========================================
+ Hits        166549   166564   +15     
+ Misses       40634    40632    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig force-pushed the bugfixes/field-sensitivity-union branch from 40bca65 to 1f52d5b Compare April 29, 2025 10:05
@tautschnig tautschnig added bugfix and removed bug labels Apr 29, 2025
When code outside the core field-sensitivity implementation produces
index expressions we must not blindly turn such expressions into
ssa_exprt.
@tautschnig tautschnig force-pushed the bugfixes/field-sensitivity-union branch from 1f52d5b to eab49c8 Compare June 25, 2025 10:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bugfix Kani Bugs or features of importance to Kani Rust Verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants