Skip to content

ansi-c: remove duplicate loc() invocations from scanner #8626

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

kroening
Copy link
Member

@kroening kroening commented Apr 9, 2025

This removes repeated calls to loc() from the ANSI-C scanner.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This removes repeated calls to loc() from the ANSI-C scanner.
@kroening kroening mentioned this pull request Apr 9, 2025
5 tasks
@kroening kroening marked this pull request as ready for review April 9, 2025 21:33
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 80.36%. Comparing base (cbdab7f) to head (7b1ae4a).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
src/ansi-c/scanner.l 0.00% 32 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8626      +/-   ##
===========================================
- Coverage    80.36%   80.36%   -0.01%     
===========================================
  Files         1686     1686              
  Lines       206799   206800       +1     
  Branches        84       84              
===========================================
  Hits        166200   166200              
- Misses       40599    40600       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig merged commit bded65a into develop Apr 9, 2025
39 of 41 checks passed
@tautschnig tautschnig deleted the ansi-c-double-loc branch April 9, 2025 22:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants