Added InputStreamCollector #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multithreaded way to collect inputStreams
jbduncan
reviewed
Feb 2, 2018
|
|
||
| private volatile IOException exception; | ||
|
|
||
| public InputStreamCollector(@Nonnull InputStream is, @Nullable PrintStream ps, @Nullable Charset cs) { |
There was a problem hiding this comment.
I think we assume that things are @Nonnull by default, similarly to how Guava and Checker Framework approach things, so I'd vote to have this instance of @Nonnull removed.
There was a problem hiding this comment.
I'm OK with that.
ralfgrossklaus
commented
Feb 2, 2018
| throw stdInputThread.getException(); | ||
| } else if (stdErrorThread.getException() != null) { | ||
| throw stdErrorThread.getException(); | ||
| } else if (exitValue != EXIT_VALUE_SUCCESS) { | ||
| throw new RuntimeException("'" + cmd + "' exited with " + exitValue); | ||
| } | ||
|
|
There was a problem hiding this comment.
Just noted this issue: Maybe it's not the best idea to re-throw exceptions from another thread without wrapping them, since the stacktrace of the exception won't match to the thread that throws it :-/
- Wrapped exceptions from other threads - Removed unnecessary @nonnull
|
Thanks very much! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multithreaded way to collect inputStreams of started process in order to prevent deadlocks when buffer for StdErr is full while parent process still tries to read from StdOut.