Fix memory leaks in gradle daemon #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror`, this way Gradle reports the root cause.
…lity to give it a chance to null-out its initializing lambda. Addresses diffplug#1194 (comment)
…elegate field, a well as a `List<FormatterStep>`. Fixes diffplug#1194 (comment)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common for
LazyForwardingEqualityto store some reference to the Gradle project in its initializing lambda, but the lambda is not used / needed once it has been run. By setting the initializing lambda tonullin thecalculateStatemethod, we make it possible for the Gradle daemon to do a more complete GC.Fixes (or at least improves) #1194.