Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Try to migrate to com.vanniktech.maven.publish #2236

Closed
wants to merge 1 commit into from

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Aug 26, 2024

No description provided.

@Goooler Goooler marked this pull request as draft August 26, 2024 06:07
@Goooler Goooler mentioned this pull request Aug 26, 2024
@nedtwigg nedtwigg marked this pull request as ready for review August 26, 2024 15:30
@nedtwigg nedtwigg marked this pull request as draft August 26, 2024 15:30
Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big change. I maintain a lot of projects, they all use a common setup, this is quite different.

On my priority list, spotless is pretty low right now, but I'm trying hard not to block others. My priorities for Spotless are

I don't think I want to merge this, and I definitely don't want to work on this until after the issues above are solved so that we can publish a proper 7.0.0, no beta.


group=com.diffplug.spotless
SONATYPE_AUTOMATIC_RELEASE=true
SONATYPE_HOST=DEFAULT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the possible values are, but I think we are on the s01 host, not the default.

  • s01.oss.sonatype.org

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, forgot updating.

@nedtwigg nedtwigg closed this Oct 25, 2024
@Goooler Goooler deleted the migrate-to-vanniktech-maven-publish branch October 26, 2024 01:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants