Skip to content

Fix remote build cache #2298

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Fix remote build cache #2298

merged 8 commits into from
Oct 15, 2024

Conversation

nedtwigg
Copy link
Member

This looks awful, but I hate to take 7.0 out of beta unless it's better than the 6.0 line, and I hate to break remote build cache (which is a beautiful design) just to satisfy configuration cache (which I think has some mistakes #987).

But this workaround isn't soooo big, it doesn't affect end users or step authors, and it makes the giant rewrite slightly more worth it.

@nedtwigg nedtwigg requested review from Goooler and jbduncan October 13, 2024 06:01
@nedtwigg
Copy link
Member Author

@Goooler @jbduncan as soon as this passes CI I plan to release this as another beta, so that we can get more miles on it before getting out of this awful never-ending beta phase. Even if it's already merged and released I would still be interested in your feedback if you have any time to take a look.

@jbduncan
Copy link
Member

jbduncan commented Oct 15, 2024

@Goooler @jbduncan as soon as this passes CI I plan to release this as another beta, so that we can get more miles on it before getting out of this awful never-ending beta phase. Even if it's already merged and released I would still be interested in your feedback if you have any time to take a look.

Great! I'm a bit busy with IRL things this week, but I should have time this weekend to have a look. If I don't get back to you for whatever reason, feel free to ping me again and to release things anyway. :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants