Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Providing WTP formatters, excluding JSP #241

Merged
merged 8 commits into from
Aug 5, 2018
Merged

Providing WTP formatters, excluding JSP #241

merged 8 commits into from
Aug 5, 2018

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented Apr 29, 2018

The following formatters are provided:

Since I was not able to get proper JSP formatting results using the Eclipse IDE, I skipped the support of the JSP model for now.

This PR depends on #234.

Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

Fixed comments. Aligned dependency version restrictions.
fvgh added 3 commits August 4, 2018 19:51
…automatically to the right location, like it has been implemented already for eclipse-groovy.

The approach is now common for all Eclipse fat-JAR formatter implementations.
@nedtwigg
Copy link
Member

nedtwigg commented Aug 4, 2018

Oh boy! Just lemme know when this ready for publishing @fvgh!

fvgh added 2 commits August 5, 2018 18:38
…he Eclipse plugin shall be used, to make the version transparent in the dependency lock files.
@fvgh fvgh merged commit f70e1c7 into master Aug 5, 2018
@fvgh
Copy link
Member Author

fvgh commented Aug 5, 2018

@nedtwigg Finally... Feel free to publish.

@nedtwigg
Copy link
Member

nedtwigg commented Aug 5, 2018

Is CDT far behind? Can I batch them together, or should I do this first?

@fvgh
Copy link
Member Author

fvgh commented Aug 6, 2018

@nedtwigg CDT will be ready in a few minutes...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants