Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable support for intelliJ placeholder for year in license header #542

Merged
merged 5 commits into from
Mar 20, 2020

Conversation

sameer-b
Copy link
Contributor

Change log

…yle. Makes it clear that an inner class ought to be used in the future, especially to support diffplug#496.
@nedtwigg
Copy link
Member

Thanks, looks very good. I made some minor tweaks to the docs and implementation. If you update the changelogs (root, plugin-gradle, and plugin-maven are all affected, and can have the same changelog entry if you want), then I'll merge and release.

@sameer-b
Copy link
Contributor Author

@nedtwigg Done! Could you take a look?

@nedtwigg
Copy link
Member

For future reference, there are three different changelogs (as documented in the PR template) - one for Spotless developers, one for the gradle plugin, and another for the maven plugin. I made a minor edit to your entry and copied it to the other affected changelogs.

Thanks for the contribution!

@nedtwigg nedtwigg merged commit 07d58e5 into diffplug:master Mar 20, 2020
@nedtwigg
Copy link
Member

Released in x.28.0

@nedtwigg
Copy link
Member

nedtwigg commented Jun 5, 2020

If you care about license headers, you should checkout ratchetFrom 'origin/master'.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants