Fix license header bug for years in range #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new field in LicenseHeaderStep: - licenseHeaderWithRange When license header contains range years then calculateYearExact should return only second year in range
|
all tests passed, and this is the result of the test on the master branch: org.junit.ComparisonFailure: Step application failed expected:<... with range, 2009-20[]21. ACME corp. |
nedtwigg
requested changes
Apr 11, 2021
lib/src/main/java/com/diffplug/spotless/generic/LicenseHeaderStep.java
Outdated
Show resolved
Hide resolved
|
Thanks! Published in |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new field in LicenseHeaderStep:
When license header contains range years then calculateYearExact
should return only second year in range
Should prevent the plugin from changing 2011-2020 to 2011-2011-2020 if the range of years is specified in the license file.