Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update changelog for 3.2.0. #97

Merged
merged 3 commits into from
Apr 3, 2017
Merged

Update changelog for 3.2.0. #97

merged 3 commits into from
Apr 3, 2017

Conversation

nedtwigg
Copy link
Member

@nedtwigg nedtwigg commented Apr 3, 2017

No description provided.

jbduncan
jbduncan approved these changes Apr 3, 2017
View reviewed changes
Copy link
Member

@jbduncan jbduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jbduncan
Copy link
Member

jbduncan commented Apr 3, 2017

Oh, probably good to mention that Formatter::compute (will) no longer throw Error!

@nedtwigg
Copy link
Member Author

nedtwigg commented Apr 3, 2017

throw Error has the same effect as throw RuntimeException - it doesn't actually mean anything. It was a mistake to have written it.

@jbduncan
Copy link
Member

jbduncan commented Apr 3, 2017

Oh I see! Then still LGTM. 👍

@nedtwigg
Copy link
Member Author

nedtwigg commented Apr 3, 2017

Between Kotlin #92, ignore failures #79, and fixing strict errors in #96, we've got some valuable fixes that are waiting on Groovy. Groovy's got a little way to go, so I'm inclined to merge #96 later today and ship the backlog.

@nedtwigg nedtwigg merged commit 00af4c9 into diffplug:master Apr 3, 2017
@nedtwigg nedtwigg deleted the changelog branch April 3, 2017 14:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jbduncan jbduncan jbduncan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nedtwigg @jbduncan