Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update to webpack@5 and webpack-cli@4. #945

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update to webpack@5 and webpack-cli@4. #945

wants to merge 5 commits into from
+36 −53

Conversation

davidlehn
Copy link
Member

@davidlehn davidlehn commented Jan 25, 2022 •
edited
Loading

Note this a breaking change for 2.x or later.

  • Remove deprecated worker-loader, enable and fix Worker tests.

@davidlehn
Update to webpack@5 and webpack-cli@4.
4cf4596 
- Update to `webpack@5` and `webpack-cli@4`.
- **BREAKING**: Update node engine to `>= 10.13.0`. Old Node.js *may*
  still work, but due to tooling upgrades, they can no longer be tested.
@davidlehn
Test on Node.js 16.x.
bed5c00
@davidlehn davidlehn added this to the v2.x milestone Jan 25, 2022
@davidlehn
Update dependencies.
a8e791a 
- webpack update requires more updates.
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022 •
edited
Loading

Codecov Report

Merging #945 (0510c98) into main (7928551) will decrease coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
- Coverage   79.84%   79.11%   -0.73%     
==========================================
  Files          42       42              
  Lines        9510     9510              
==========================================
- Hits         7593     7524      -69     
- Misses       1917     1986      +69
Impacted Files Coverage Δ
lib/prime.js 12.26% <0.00%> (-37.74%) ⬇️
lib/rsa.js 72.72% <0.00%> (-5.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7928551...0510c98. Read the comment docs.

@davidlehn
Remove old node overrides.
b14f9b7 
- Not used in webpack@5.
@davidlehn
Disable worker tests.
0510c98 
- worker-loader deprecated in webpack@5 but still using here for now.
- karma having issues serving the files.
@davidlehn davidlehn mentioned this pull request Jan 25, 2022
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@arnonrdp arnonrdp arnonrdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.x
Development

Successfully merging this pull request may close these issues.
3 participants
@davidlehn @codecov-commenter @arnonrdp