Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

doctl: get, list, update and delete interconnect attachment #1636

Merged
merged 14 commits into from
Feb 10, 2025
Merged

doctl: get, list, update and delete interconnect attachment #1636

merged 14 commits into from
Feb 10, 2025

Conversation

guptado
Copy link
Contributor

@guptado guptado commented Jan 7, 2025 •
edited
Loading

Testing:

List PIA:

doctl --context s2 network --type "partner" interconnect-attachment list
image

Get PIA:

doctl --context s2 network --type "partner" interconnect-attachment get d73a746c-1426-405e-87c7-0cb3e332fb6a
image

Delete PIA:

doctl --context s2 network --type "partner" interconnect-attachment delete 38142707-c815-413e-a10a-b40a93ecd088
image

Update PIA:

doctl --context s2 network --type "partner" interconnect-attachment update f24c9665-c400-40c8-a515-dcb24342334a --name "7Feb-updated" --vpc-ids "270a76ed-1bb7-4c5d-a6a5-e863de086940"
image

guptado
guptado commented Jan 7, 2025
View reviewed changes
apinonformoso
apinonformoso approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@apinonformoso apinonformoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approving (I know it will be blocked until godo implementation is in)

@apinonformoso
Copy link
Contributor

If #1646 gets merged first you will need to rebase this branch and remove some code.

@guptado guptado changed the title [do-not-review] [do-not-merge] doctl: list and get interconnect attachment doctl: list and get interconnect attachment Feb 5, 2025
@guptado guptado marked this pull request as ready for review February 5, 2025 13:14
@guptado guptado changed the title doctl: list and get interconnect attachment doctl: get, list, update and delete interconnect attachment Feb 7, 2025
bentranter
bentranter requested changes Feb 10, 2025
View reviewed changes
Copy link
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small pieces of feedback around formatting and flag parsing

bentranter
bentranter approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bentranter bentranter merged commit f28d848 into digitalocean:main Feb 10, 2025
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bentranter bentranter bentranter approved these changes

@apinonformoso apinonformoso apinonformoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guptado @apinonformoso @bentranter