Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

load-balancers: add support for disable_lets_encrypt_dns_records field #286

Merged
merged 1 commit into from
Oct 20, 2021
Merged

load-balancers: add support for disable_lets_encrypt_dns_records field #286

merged 1 commit into from
Oct 20, 2021

Conversation

dikshant
Copy link
Contributor

This adds support for the new disable_lets_encrypt_dns field which will disable automatic DNS record creation using the root domain when a let's encrypt cert is added to a load balancer.

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I left a small suggestion in line.

@andrewsomething andrewsomething self-requested a review October 20, 2021 16:35
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@andrewsomething andrewsomething self-requested a review October 20, 2021 16:36
@andrewsomething andrewsomething merged commit b62a2ef into digitalocean:main Oct 20, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants