Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(path): broken tag/category link when containing a dot #368

Merged
merged 5 commits into from
May 18, 2020
Merged

fix(path): broken tag/category link when containing a dot #368

merged 5 commits into from
May 18, 2020

Conversation

wtchangdm
Copy link
Contributor

Hi, thank you for this great theme! I noticed an issue that certain tags (like Node.js) at footer disappear somehow.

After some investigations, it looks like the same problem as this: HugoBlox/hugo-blox-builder@4ed72d8

I've confirmed that this fixes the issue and other tags are still working fine.

@wtchangdm
Copy link
Contributor Author

Turns out category links have the same problem. I think that's all?

@wtchangdm wtchangdm changed the title Fix broken tag link when tag contains a dot Fix broken tag/category link when containing a dot May 17, 2020
@dillonzq
Copy link
Owner

@wtchangdm That's all. Thanks.
This problem should only appear where GetPage is used.

@dillonzq
Copy link
Owner

Hi, @wtchangdm
When handling East Asia words, such as Chinese, urlize will encode them, which causes .Site.GetPage to fail.

There is a discussion on the Hugo forum:
https://discourse.gohugo.io/t/how-decode-urls-in-hugo/7549

And there seems to be a perfect solution for East Asia words and dots.

I make it a partial in function/path.html.

@dillonzq dillonzq added the bug Something isn't working label May 18, 2020
@dillonzq dillonzq changed the title Fix broken tag/category link when containing a dot fix(path): broken tag/category link when containing a dot May 18, 2020
@dillonzq dillonzq merged commit e5ae1d6 into dillonzq:develop May 18, 2020
@wtchangdm
Copy link
Contributor Author

wtchangdm commented May 18, 2020 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants