Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update for Bevy 0.11-dev : Schedule-First API. #362

Closed
wants to merge 7 commits into from

Conversation

flmng0
Copy link

@flmng0 flmng0 commented Apr 20, 2023

Good Morning/Afternoon, Dimforge Team,

I have forked the repo and written changes required to work with the new Schedule-First API.

The API has been devised in bevyengine/bevy#8079, and I wanted to use them ASAP, so I thought I'd make my efforts public.

TL;DR for the above PR: add_startup_system/add_system have been deprecated in favour of add_systems. Render has its own ScheduleLabel now as well.

FYI: this is the first time I've ever contributed to an open-source project, so please let me know if there's anything I could have done differently.

Reminder: I changed the Cargo dependency for bevy to use the GitHub URL, please change to 0.11 once it has been finalised.

^ I don't mean to seem condescending in the line above, I just know that I would forget to change it, so I'm trying to be courteous.

@iwek7
Copy link

iwek7 commented Jun 11, 2023

As of bevy c1fd505f9 this PR is no longer enough to compile bevy_rapier because there are more breaking changes. I managed to compile bevy_rapier_2d doing following simple changes:

  • deriving event on some ecs events (change introduced by 89cbc78)
  • changing function name apply_system_buffers to apply_deffered (change introduced by cbd4abf0fccf595fa08906608001885ff261a144)

After this I was left with only couple hundred mysterious type conversion errors between glam types. I determined that most probable culprit is updating glam version to 0.24 (0736195a1eb9a7e07386d0b27f63baa1fa4b7824). Indeed this causes rapier to have 2 different glam versions because nalgebra depends on 0.23 and support for 0.24 waits for approval (dimforge/nalgebra#1242). After compiling nalgebra with patch from that pr and using this version in bevy_rapier I had to also compile versions of parry and rapier that use my custom nalgebra with glam 0.24 support. Sadly rapier 3d does not compile with custom parry3d so I just ignored 3d because I don't need it anyways. Anyways after plugin all those custom libs into rapier_bevy_2d it compiled finally without issues.

@flmng0 flmng0 closed this Jul 19, 2023
@flmng0
Copy link
Author

flmng0 commented Jul 19, 2023

This was implemented by #380

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants