Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same profiling on Large Collection example(increasing the number of rendered nodes to be ~230k) showed the following results:
replaceNodeFromTree
master
For a simple action
replaceNodeFromTree
takes ~500ms to run, this makes the UI look strangehere
As the image shows the time that
replaceNodeFromTree
takes to run is now residual and the burden is ongetFlattenedTree
It means that the next step will be to try to add some kind of memoization to
getFlattenedTree
so that it only needs flatten the strictly necessary nodes and keep the old ones in memory while still possible