This repository has been archived by the owner on Aug 28, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 83
Typings (Second attempt, damn you CRLF) #26
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bc9dbbf
Typings
kyranet c6cac4f
why u don't upload
kyranet b346925
More changes
kyranet 6bc0102
Added overloads to fix TS issues.
kyranet 05b149b
Multiple bugfixes, all typings for all pieces.
kyranet 15787fd
Ao's requested change
kyranet 7e5b4c5
Added typings for extended classes
kyranet 6c7ec0d
Fix Now, it should have been number.
kyranet 3f03fe9
I don't think they should be exported... they're not in Klasa.
kyranet 3bcca7e
Added events, Settings type.
kyranet 82a112f
The SemiColons. Part 1. (Wake up Travis-CI)
kyranet 8c9b1a3
TSLint (Do not confuse with ESLint), added scripts in package.json
kyranet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
* text=auto eol=lf |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
{ | ||
"rules": { | ||
"no-inferrable-types": [false], | ||
"no-unused-expression": true, | ||
"no-duplicate-variable": true, | ||
"no-unused-variable": [true, {"ignore-pattern": "^_"}], | ||
"no-shadowed-variable": true, | ||
"comment-format": [ | ||
true, "check-space" | ||
], | ||
"indent": [ | ||
true, "tabs" | ||
], | ||
"curly": false, | ||
"class-name": true, | ||
"semicolon": [true], | ||
"triple-equals": true, | ||
"eofline": true, | ||
"no-bitwise": false, | ||
"no-console": [false], | ||
"member-access": [true, "check-accessor", "check-constructor"], | ||
"no-consecutive-blank-lines": [true], | ||
"no-parameter-properties": true, | ||
"one-line": [ | ||
false | ||
], | ||
"variable-name": [true, "ban-keywords", "check-format", "allow-leading-underscore"], | ||
"interface-name": [true, "always-prefix"], | ||
"no-conditional-assignment": true, | ||
"use-isnan": true, | ||
"no-trailing-whitespace": true, | ||
"quotemark": [true, "single", "avoid-escape"], | ||
"no-use-before-declare": true, | ||
"whitespace": [true, | ||
"check-branch", | ||
"check-decl", | ||
"check-operator", | ||
"check-module", | ||
"check-separator", | ||
"check-type", | ||
"check-typecast" | ||
], | ||
"typedef-whitespace": [ | ||
true, | ||
{ | ||
"call-signature": "nospace", | ||
"index-signature": "nospace", | ||
"parameter": "nospace", | ||
"property-declaration": "nospace", | ||
"variable-declaration": "nospace" | ||
}, | ||
{ | ||
"call-signature": "onespace", | ||
"index-signature": "onespace", | ||
"parameter": "onespace", | ||
"property-declaration": "onespace", | ||
"variable-declaration": "onespace" | ||
} | ||
] | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should just be a string here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, in the typings, I wrote
But wrote the wrong type in the JSDocs (got confused with Command). Fixed 👍