Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove RN Android's bizarre font weight extension pattern #32

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

stevenpetryk
Copy link

@stevenpetryk stevenpetryk commented Nov 21, 2022

This is a simple change to ignore the way that RN's Android code searches for fonts with a _bold, _italic, or _bold_italic suffix in their filename. In Discord's codebase we just declare the font family, but some of our libraries don't do that (namely react-navigation), so this change should help an issue where some headings are using Roboto because this is trying to find a font matching fontWeight: 700.

We'll need to revert this change once we rework how we do fonts on RN (since currently we're a bit off-book).

@stevenpetryk stevenpetryk changed the base branch from master to 0.68-discord-1 November 21, 2022 20:48
@stevenpetryk stevenpetryk changed the title fonts/ignore weight extension Remove RN Android's bizarre font weight extension pattern Nov 21, 2022
@github-actions
Copy link

Fails
🚫

❗ Base Branch - The base branch for this PR is something other than main or a -stable branch. Are you sure you want to target something other than the main branch?

🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
⚠️ 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against ce20ba5

@stevenpetryk stevenpetryk marked this pull request as ready for review November 21, 2022 20:50
@stevenpetryk stevenpetryk merged commit e79fc6d into 0.68-discord-1 Nov 21, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant