Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds Android 14 support to DevSupportManagerBase #47

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

AndyG
Copy link

@AndyG AndyG commented Nov 3, 2023

Analogous to facebook#38256

This adds a compatibility support method compatRegisterReceiver to support new changes in android 14 around broadcast receivers.

from the upstream PR:

Summary:
Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.

Without this fix, app crashes during launch because of :
SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts

Differential Revision: D47313501

@AndyG AndyG self-assigned this Nov 3, 2023
@AndyG AndyG requested review from Flewp and yayvery November 3, 2023 21:18
Copy link

@yayvery yayvery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@AndyG AndyG merged commit 7ae8fa5 into 0.72.3-discord-1 Nov 3, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants