fix(Guild#deleteEmoji): reject non emojis / emoji IDs (#2793)

* fix(Guild#deleteEmoji): Performing wrong checks * fix: requested changes `a string` -> `an id` * fix: requested changes `id` -> `ID`
discordjs · Aug 29, 2018 · cd58599 · cd58599
1 parent b83fdbf
commit cd58599
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/structures/Guild.js b/src/structures/Guild.js
@@ -1114,7 +1114,8 @@ class Guild {
    * @returns {Promise}
    */
   deleteEmoji(emoji, reason) {
-    if (!(emoji instanceof Emoji)) emoji = this.emojis.get(emoji);
+    if (typeof emoji === 'string') emoji = this.emojis.get(emoji);
+    if (!(emoji instanceof Emoji)) throw new TypeError('Emoji must be either an instance of Emoji or an ID');
     return this.client.rest.methods.deleteEmoji(emoji, reason);
   }