Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: user-installable apps #10227

Merged
merged 54 commits into from
Sep 1, 2024
Merged

Conversation

Syjalo
Copy link
Contributor

@Syjalo Syjalo commented Apr 24, 2024

Please describe the changes this PR makes and why it should be merged:
This PR adds support for User-Installable Apps

Depends on:

This PR will be in Draft status during the preview state of User-Installable Apps

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2024 8:40pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2024 8:40pm

@Syjalo Syjalo changed the title feat: add support for user-installable apps feat: user-installable apps Apr 24, 2024
@Syjalo Syjalo force-pushed the feat/user-installable-app branch from 0572167 to 5088fad Compare April 27, 2024 17:14
@SuperchupuDev
Copy link
Contributor

this pr does not close #10215 btw, this updates discord.js but not the builders (the linked issue only requested it for builders)

@Jiralite
Copy link
Member

Jiralite commented May 4, 2024

This is a draft. It is not finalised yet.

@SuperchupuDev
Copy link
Contributor

i know, just pointing it out as the description isnt accurate right now 🤷‍♀️

@GeekCornerGH
Copy link

GeekCornerGH commented Jun 12, 2024

@Syjalo Discord said the user-installable apps will come out of beta on June 18th, can I help with something to get this pr done?

@Jiralite Jiralite removed the blocked label Jun 27, 2024
@Jiralite Jiralite added this to the discord.js 14.16 milestone Jun 27, 2024
@Syjalo Syjalo marked this pull request as ready for review June 27, 2024 19:27
@Syjalo Syjalo requested a review from a team as a code owner June 27, 2024 19:27
@Syjalo Syjalo requested review from vladfrangu, iCrawl and kyranet June 27, 2024 19:27
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Oct 4, 2024
* feat: inital user-installable apps support

* docs: add deprecation warnings

* feat: add equality checks

* fix: possibly `null` cases

* docs: tweaks

* docs: add deprecations

* fix(ApplicationCommandManager): amend transform command

* feat: properly support `integration_types_config`

* docs: add .

* docs: minor changes

* featBaseApplicationCommandData): update type

* style: prettier

* chore: fix issues

* fix: correct casing

Co-authored-by: Superchupu <53496941+SuperchupuDev@users.noreply.github.com>

* refactor: remove console log

* fix: use case that satisfies `/core` and the API

* fix: `oauth2InstallParams` property is not nullable

* fix: do not convert keys into strings

* feat: update transforer to return the full map

* feat: update transformers

* feat: add `PartialGroupDMMessageManager `

Hope this is not a breaking change

* docs: fix type

* feat: add approximate count of users property

* fix: messageCreate doesn't emit in PartialGroupDMChannel

* fix: add GroupDM to TextBasedChannelTypes

* feat: add NonPartialGroupDMChannel helper

* fix: expect PartialGroupDMChannel

* feat: narrow generic type

* test: exclude PartialGroupDMChannel

* feat: use structure's channel type

* docs: narrow type

* feat: remove transformer

* refactor: remove unnecessary parse

* feat: add APIAutoModerationAction transformer

* fix: use the right transformer during recursive parsing of interaction metadata

* docs: add external types

* docs: add `Message#interactionMetadata` property docs

* docs: make nullable

* docs: add d-docs link

* docs: use optional

* fix: make `oauth2InstallParams` nullable

* types: update `IntegrationTypesConfiguration`

Co-authored-by: Almeida <github@almeidx.dev>

* docs: update `IntegrationTypesConfigurationParameters`

Co-authored-by: Almeida <github@almeidx.dev>

* types: update `IntegrationTypesConfigurationParameters`

* refactor: improve readability

* docs: mark integrationTypesConfig nullable

* refactor: requested changes

---------

Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Superchupu <53496941+SuperchupuDev@users.noreply.github.com>
Co-authored-by: Vlad Frangu <me@vladfrangu.dev>
Co-authored-by: Almeida <github@almeidx.dev>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

10 participants