Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(Webhook): add url getter #3178

Merged
merged 4 commits into from
Apr 5, 2019
Merged

feat(Webhook): add url getter #3178

merged 4 commits into from
Apr 5, 2019

Conversation

izexi
Copy link
Contributor

@izexi izexi commented Apr 4, 2019

You're able to retrieve this using the client, so it would be a nice little helper getter that the library could provide instead of having to construct this yourself.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

bdistin
bdistin suggested changes Apr 4, 2019
View reviewed changes
src/structures/Webhook.js Outdated Show resolved Hide resolved
bdistin
bdistin suggested changes Apr 4, 2019
View reviewed changes
src/structures/Webhook.js Outdated Show resolved Hide resolved
@SpaceEEC SpaceEEC merged commit c078682 into discordjs:master Apr 5, 2019
@izexi izexi deleted the Webhook-url branch April 5, 2019 10:24
SpaceEEC added a commit to SpaceEEC/discord.js that referenced this pull request Jan 18, 2020
@SpaceEEC
feat(Webhook): add url getter
fdd328e 
This backports: discordjs#3178
@SpaceEEC SpaceEEC mentioned this pull request Jan 18, 2020
Merged
5 tasks
SpaceEEC added a commit that referenced this pull request Jan 24, 2020
@SpaceEEC
feat(Webhook): backport missing properties (#3710)
30adb37 
* feat(Webhook): add avatarURL getter

This backports: #3625

* feat(Webhook): add type, createAt, and createdTimestamp

This backports: #3585

* feat(Webhook): add url getter

This backports: #3178

* docs(Webhook): add missing type and readonly tags
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@izexi @samsamson33
feat(Webhook): add url getter (discordjs#3178)
6b64722 
* add Webhook#url

* set typing as readonly

* suggested change

* another one
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@samsamson33
Revert "feat(Webhook): add url getter (discordjs#3178)"
d25e364 
This reverts commit 6b64722.
@baby636 baby636 mentioned this pull request Apr 25, 2023
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bdistin bdistin bdistin requested changes

@appellation appellation appellation approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@izexi @appellation @bdistin @SpaceEEC