Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Backport documentation fixes #3683

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Backport documentation fixes #3683

merged 2 commits into from
Jan 13, 2020

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Jan 12, 2020 •
edited
Loading

https://github.com/discordjs/discord.js/projects/5#card-31518709
https://github.com/discordjs/discord.js/projects/5#card-31518720

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@monbrey monbrey changed the title Presence does not extend Base, therefore presence.client was undocumented Backport documentation fixes Jan 12, 2020
@amishshah amishshah merged commit f6d1db6 into discordjs:11.5-dev Jan 13, 2020
@monbrey monbrey deleted the 11.5-presence branch January 20, 2020 21:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@amishshah amishshah amishshah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monbrey @amishshah @SpaceEEC