FEATURE: Add Discover in bottom tabs #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmusaraj
commented
Jun 13, 2024
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| import React, {useContext} from 'react'; | |||
| import {Dimensions, View} from 'react-native'; | |||
| import {Bar} from 'react-native-progress'; | |||
| import Bar from 'react-native-progress/Bar'; | |||
There was a problem hiding this comment.
This change makes the RNSVG dependency unnecessary.
pmusaraj
commented
Jun 13, 2024
| } | ||
|
|
||
| // TODO(pmusaraj): remove after June 2024 | ||
| // once most sites will have received the new API at /notifications/totals.json |
There was a problem hiding this comment.
removes fallback for old notifications code via session.
pmusaraj
changed the title
CvX
reviewed
Jun 19, 2024
And remove fallback code for oldish instances. They now won't have group inbox links. (It's a very minor feature, we can easily live without them.)
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
pmusaraj
force-pushed
the
add-discover-in-bottom-tabs
branch
from
53a392e to
683884e
Compare
CvX
approved these changes
Jun 20, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large PR, sorry in advance!
This includes: