Better external auth integration, restore + site button, tests! #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authentication now uses ephemeral session, plus captures external auth properly on sites that use it. Also adds a button to add a single site much like we did before adding Discover to the app (requested by users on meta).
Similar to what Safari does when it runs into a crash, should help with odd crashes on iPad. Reported in https://meta.discourse.org/t/327190
pmusaraj
commented
Oct 23, 2024
There was a problem hiding this comment.
At last, we can give iOS only 1 icon file and have it handle all sizes on its own!
markvanlan
reviewed
Oct 30, 2024
| @@ -561,8 +547,9 @@ class Discourse extends React.Component { | |||
| tabBarBackground: () => this._blurView(theme.name), | |||
| }}> | |||
| <Tab.Screen | |||
| name={i18n.t('home')} | |||
| name="Home" | |||
There was a problem hiding this comment.
I know this was intentional but it's ok to lose i18n?
There was a problem hiding this comment.
Yeah, this was a pretty stupid regression on my part. It caused some ugly routing errors for users on non-English locales. (That's why there are tests for this now.)
markvanlan
approved these changes
Oct 30, 2024
|
Thanks @markvanlan! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes:
Plus, some basic e2e tests have been added!