Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Feature] Allow to use custom query parameters #236

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[Feature] Allow to use custom query parameters #236

merged 1 commit into from
Dec 2, 2024

Conversation

MelaineGerard
Copy link
Contributor

No description provided.

@MelaineGerard
Copy link
Contributor Author

This PR resolve the issue when we want to send webhooks in thread.
As we need to use a query parameters for that, it breaks the URL when sending the webhooks due to the fact that you added ?wait=true on the url

@davidtaylorhq
Copy link
Member

Thanks @MelaineGerard! Please can you correct the linting failure, and then we'll be good to merge.

@MelaineGerard MelaineGerard force-pushed the main branch 2 times, most recently from 0d337c9 to 74f8d19 Compare December 2, 2024 12:40
@MelaineGerard
Copy link
Contributor Author

It should now be fixed !

@davidtaylorhq davidtaylorhq merged commit 3450662 into discourse:main Dec 2, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidtaylorhq davidtaylorhq davidtaylorhq approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MelaineGerard @davidtaylorhq