Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Container list block does not consider children of unittitle #80

Open
ctgraham opened this issue Nov 5, 2021 · 0 comments · May be fixed by #81
Open

Container list block does not consider children of unittitle #80

ctgraham opened this issue Nov 5, 2021 · 0 comments · May be fixed by #81

Comments

@ctgraham
Copy link

ctgraham commented Nov 5, 2021

The Container List block draws the text() directly from unittitle:

$title = $this->xpath->evaluate('normalize-space(string(ead:did/ead:unittitle/text()))', $element);
$date = $this->xpath->evaluate('normalize-space(string(ead:did/ead:unitdate/text()))', $element);

but, unittitle may contain all text in its children. E.g.:

<did>
  <unittitle>
    <title render="italic">My Publication Name</title>
  </unittitle>
  <unitid>12.</unitid>
</did>

A quick fix is to pull text nodes from descendant-or-self.

ctgraham added a commit to ulsdevteam/islandora_solution_pack_manuscript that referenced this issue Nov 5, 2021
ctgraham added a commit to ulsdevteam/islandora_solution_pack_manuscript that referenced this issue Apr 15, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
1 participant