Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IAB fullscreen does not work #86

Open
ctgraham opened this issue Jun 8, 2022 · 0 comments · May be fixed by #87
Open

IAB fullscreen does not work #86

ctgraham opened this issue Jun 8, 2022 · 0 comments · May be fixed by #87

Comments

@ctgraham
Copy link

ctgraham commented Jun 8, 2022

The Internet Archive Bookreader full-screen reading option does not function with this the rendering of Manuscripts.

The Islandora Internet Archive Bookreader module presumes that the fullscreen button will act on a div with the id of "book-viewer":
https://github.com/Islandora/islandora_internet_archive_bookreader/blob/691ba69a22a93e199f56288295efe7ca0e22ee46/js/islandora_book_reader.js#L836-L843

But the theming of the manuscript solution pack's manuscript view names this div as "manuscript-viewer":

islandora_solution_pack_manuscript/islandora_manuscript.module

Lines 182 to 184 in c0fee29

'viewer_wrapper_attributes' => array(
'id' => 'manuscript-viewer',
),

ctgraham added a commit to ulsdevteam/islandora_solution_pack_manuscript that referenced this issue Jun 8, 2022
@ctgraham
discoverygarden#86: Enable fullscreen with IAB
433cdee
@ctgraham ctgraham linked a pull request Jun 8, 2022 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

discoverygarden#86: Enable fullscreen with IAB ulsdevteam/islandora_solution_pack_manuscript
1 participant
@ctgraham