Adding option of submitting saved solutions #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option --submission_folder can be used to choose a location for saving solutions, this enables the student to keep several versions of its solutions. If the --record_submission option is set the selected parts will be saved ini the folder given in --submission_folder option, if the option is missing the script will behave exactly as the previous version. If --record_submission is not passed and the --submission_folder is given, instead of computing the solutions the script will submit the solution previously saved int the selected folder.
ccoffrin
reviewed
Jul 29, 2017
submit.py
Outdated
| # store submissions if requested | ||
| if args.record_submission == True: | ||
| print('Recording submission as files') | ||
| for sid, submission in results.items(): | ||
| for sid, submission in results.iteritems(): |
There was a problem hiding this comment.
CI is failing becouse this is not python3 compatible.
I use python 2.x. In python 2.x is preferable to use iteritems because it does not create an additional list, I was not aware that it was incompatible with Python 3.
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=========================================
- Coverage 89.48% 88.6% -0.88%
=========================================
Files 17 17
Lines 1056 1071 +15
=========================================
+ Hits 945 949 +4
- Misses 111 122 +11
Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option --submission_folder can be used to choose a location for saving solutions, this enables the student to keep several versions of its solutions.
If the --record_submission option is set the selected parts will be saved ini the folder given in --submission_folder option, if the option is missing the script will behave exactly as the previous version. If --record_submission is not passed and the --submission_folder is given, instead of computing the solutions the script will submit the solution previously saved int the selected folder.