Skip to content

test: drop FastAPI dependency #155

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

achille-roussel
Copy link
Contributor

This PR removes the FastAPI dependency from dispatch.test.

FastAPI is now only required if dispatch.fastapi is imported, and all unit tests that rely on FastAPI are in tests/test_fastapi.py.

I am making this change to enable importing dispatch.test without taking a FastAPI dependency, in preparation of adding new APIs in this package.

@achille-roussel achille-roussel added the testing Issue or change related to testing label Apr 25, 2024
@achille-roussel achille-roussel self-assigned this Apr 25, 2024
@achille-roussel achille-roussel force-pushed the drop-fastapi-dependency-from-test-package branch from 3df1960 to 367c065 Compare April 25, 2024 02:26
@achille-roussel achille-roussel changed the base branch from main to mypy-1.10.0 April 25, 2024 02:26
Signed-off-by: Achille Roussel <achille.roussel@gmail.com>
Signed-off-by: Achille Roussel <achille.roussel@gmail.com>
Signed-off-by: Achille Roussel <achille.roussel@gmail.com>
@achille-roussel achille-roussel force-pushed the drop-fastapi-dependency-from-test-package branch from 367c065 to 831feea Compare April 25, 2024 17:05
@achille-roussel achille-roussel merged commit 8a92dbf into mypy-1.10.0 Apr 25, 2024
7 checks passed
@achille-roussel achille-roussel deleted the drop-fastapi-dependency-from-test-package branch April 25, 2024 17:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
testing Issue or change related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants