Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Remove contentful. #619

Merged
merged 2 commits into from
Sep 13, 2022
Merged

chore: Remove contentful. #619

merged 2 commits into from
Sep 13, 2022

Conversation

jtfairbank
Copy link
Contributor

@jtfairbank jtfairbank commented Sep 13, 2022

Remove Contentful as a dependency, and related unused source files.

Makes progress on #170

@ghost
Copy link

ghost commented Sep 13, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@jtfairbank
Copy link
Contributor Author

@coderbyheart seems like the auto-format bot is going to have issues with data from Forestry, b/c Forestry commits directly to saga anyone branching off saga will have unformatted files in /content that the bot will try to clean up.

I'd recommend turning off formatting for /content/** to prevent this, or avoiding squashing commits so that the bots broader set of changes don't get squashed into the PR-specific changes.

@coderbyheart
Copy link
Member

Yes, good idea.

@coderbyheart
Copy link
Member

Done in fa8a538

@coderbyheart coderbyheart merged commit a6ec08a into saga Sep 13, 2022
@coderbyheart coderbyheart deleted the chore/170/remove-contentful branch September 13, 2022 18:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants