fix: wait all jobs done #1010
Merged
fix: wait all jobs done #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KevinWu0904 <KevinWu0904@outlook.com>
|
Actually, the underlaying robig/cron lib's stop function will return a context for developers to wait. So if we want to stop all jobs gracefully, maybe we should wait the context done. Correct me if any problems, thanks!
|
|
What problem does this solve? |
|
@yvanoers I managed to reproduce the case when gracefully exiting the jobs doesn't write the finished status because the raft layer is already gone, but with this change and another small change, the final status is correctly recorded, see So I will merge this and create a new PR with the extra change |
|
@Victorcoder Thanks ! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: KevinWu0904 KevinWu0904@outlook.com