Execution load balancing #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests didn't work by unknown reason |
|
It should work if you rebase master here |
missing import added
andreygolev
force-pushed
the
execution_balancing
branch
from
37d2b65
to
3a94510
Compare
Rebase didn't help |
|
Check the tests, it's failing in |
…ter it was chosen
|
There was a bug, indeed. Very bad one :) Now fixed. |
Good to have tests then 👍 |
vcastellm
approved these changes
Mar 10, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serf.Members() seems to usually return same order of nodes.
When we have job definition with tag "label:1", the job is executed usually on the same worker agent .
This PR adds shuffling, before returning a node for execution.
After shuffling is added, we see good load distribution among worker pool with matching tag.