Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prometheus metrics. Configurable timeout and memory limit #758

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andreygolev
Copy link
Contributor

Here were have:

  • configurable timeout for job execution
  • configurable memory limit for a shell job
  • prometheus realtime cpu and memory consumption while it's working
  • prometheus push style metrics after job execution. Useful for monitoring if job was executed in time (that's how we found misses of executions). Also there: exit code, duration of a job, last execution timestamp,

In cases anyone needs it, we can add a flag to turn on/off metrics expose through prometheus.

Copy link
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great contribution thanks! But can you split this in several PRs each one with one of the features?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants