Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix panic on recovering cluster (with peers.json) #882

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

fopina
Copy link
Contributor

@fopina fopina commented Jan 6, 2021

This is an attempt to fix #767

Not entirely sure if this is the proper way to initialize the store but I tested locally and seems to work

  • Spun up cluster with 3 server nodes, added jobs and executed them (for more data in the raft log).
  • Killed all 3 and restarted just one - leadership not acquired as missing quorum
  • Added that single node to peers.json and restarted it - leadership acquired and all the data shown

Copy link
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@vcastellm vcastellm merged commit 8c9b146 into distribworks:master Jan 6, 2021
@fopina fopina deleted the patch-2 branch January 22, 2023 22:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node crashes when providing a peers.json file
2 participants