Improve tests for http executor #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While troubleshooting issues with HTTP jobs, I noticed that test cases that I expected to fail, were not causing the test to fail. I dug in and realilzed that the errors from the output were not being checked. The returned error was being checked, but this is hardcoded to nil in the return so it offers very little value. This adds some common test cases for the HTTP executor and ensures that many input validations return an error and known good configurations work as expected. This also updates the Dockerfile to go 1.16 because 1.15 does not include go:embed and was causing `make test` to fail.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While troubleshooting issues with HTTP jobs, I noticed that test cases that I expected to fail, were not causing the test to fail. I dug in and realized that the errors from the output were not being checked. The returned error was being checked, but this is hard coded to nil in the return so it offers very little value.
This adds some common test cases for the HTTP executor and ensures that many input validations return an error and known good configurations work as expected.
This also updates the Dockerfile to go 1.16 because 1.15 does not include go:embed and was causing
make testto fail.New Test Output: