Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WIP: binaryimage rotation #91

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP: binaryimage rotation #91

wants to merge 4 commits into from

Conversation

Kinatzo
Copy link
Contributor

@Kinatzo Kinatzo commented Jun 1, 2022

Doesn't seem very easy to get 3d rotation working with SVG-to-PDFKit..

This is the parsing code:
image

Will see if it's possible the rotation.

@Kinatzo Kinatzo changed the title start binaryimage rotation WIP: start binaryimage rotation Jun 1, 2022
@Kinatzo Kinatzo changed the title WIP: start binaryimage rotation WIP: binaryimage rotation Jun 1, 2022
@Kinatzo
Copy link
Contributor Author

Kinatzo commented Jun 1, 2022

Fixes #90.

@Kinatzo Kinatzo self-assigned this Jun 1, 2022
@Kinatzo
Copy link
Contributor Author

Kinatzo commented Jun 1, 2022

Exporters:

  • Svg
  • React svg
  • Svg Abstract doc
  • Png Abstract doc
  • Jpeg Abstract doc

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Patch coverage: 54.16% and project coverage change: -0.30 ⚠️

Comparison is base (47dcd3d) 82.99% compared to head (52f0056) 82.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   82.99%   82.69%   -0.30%     
==========================================
  Files          64       64              
  Lines        2164     2179      +15     
  Branches      498      506       +8     
==========================================
+ Hits         1796     1802       +6     
- Misses        193      194       +1     
- Partials      175      183       +8     
Impacted Files Coverage Δ
...rc/abstract-document-exporters/pdf/render-image.ts 68.86% <ø> (ø)
packages/abstract-image/src/model/component.ts 95.65% <ø> (ø)
...act-image/src/exporters/react-svg-export-image.tsx 87.15% <46.66%> (-6.85%) ⬇️
...s/abstract-image/src/exporters/svg-export-image.ts 82.10% <62.50%> (-0.12%) ⬇️
packages/abstract-image/src/model/point.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant