Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removed pinned django-treebeard #59

Merged
merged 3 commits into from
May 26, 2023
Merged

Removed pinned django-treebeard #59

merged 3 commits into from
May 26, 2023

Conversation

tidenhub
Copy link
Contributor

@tidenhub tidenhub commented May 24, 2023

Description

This change removes an old issue protecting broken changes in django-treebeard 4.5.0 where the core CMS and treebeard has since received patches.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #59 (472d904) into master (029016e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #59   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          143       143           
  Branches        34        25    -9     
=========================================
  Hits           143       143           

@fsbraun
Copy link
Member

fsbraun commented May 24, 2023

@tidenhub thank you so much for this PR. Can you please add an entry into the change log? Thank you so much.

@tidenhub
Copy link
Contributor Author

@fsbraun Done.

CHANGELOG.rst Outdated Show resolved Hide resolved
@fsbraun fsbraun merged commit 296bd89 into django-cms:master May 26, 2023
@fsbraun fsbraun mentioned this pull request Dec 6, 2023
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants