Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat: Django 4.2 support #61

Merged
merged 15 commits into from
Dec 6, 2023

Conversation

mogoh
Copy link
Contributor

@mogoh mogoh commented Aug 2, 2023

Description

Work in progress, not ready to merge yet.

Related resources

#61

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (296bd89) 100.00% compared to head (51d929b) 100.00%.

❗ Current head 51d929b differs from pull request most recent head 38b1a9a. Consider uploading reports for the commit 38b1a9a to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        11    +1     
  Lines          143       148    +5     
  Branches        25        25           
=========================================
+ Hits           143       148    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mogoh mogoh force-pushed the feat-django-4-2-support branch 3 times, most recently from ae89059 to 5d01809 Compare August 21, 2023 12:58
@mogoh mogoh marked this pull request as ready for review August 21, 2023 16:10
@mogoh
Copy link
Contributor Author

mogoh commented Aug 21, 2023

Please review.

Copy link
Contributor

@tidenhub tidenhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me.

@fsbraun fsbraun closed this Dec 6, 2023
@fsbraun fsbraun reopened this Dec 6, 2023
Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @mogoh

@fsbraun fsbraun merged commit beed4a2 into django-cms:master Dec 6, 2023
6 checks passed
@fsbraun fsbraun mentioned this pull request Dec 6, 2023
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants