Skip to content

Use default app config discovery #1467

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

francoisfreitag
Copy link
Contributor

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #1467 (73c24d6) into main (7f2ad72) will decrease coverage by 0.25%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1467      +/-   ##
==========================================
- Coverage   86.47%   86.22%   -0.26%     
==========================================
  Files          35       35              
  Lines        1849     1851       +2     
  Branches      258      259       +1     
==========================================
- Hits         1599     1596       -3     
- Misses        178      182       +4     
- Partials       72       73       +1     
Impacted Files Coverage Δ
debug_toolbar/__init__.py 66.66% <33.33%> (-33.34%) ⬇️
debug_toolbar/panels/profiling.py 86.60% <0.00%> (-2.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2ad72...73c24d6. Read the comment docs.

@matthiask
Copy link
Member

Looks good, thanks!

@matthiask matthiask merged commit cdb6b7e into django-commons:main Apr 23, 2021
@francoisfreitag francoisfreitag deleted the default-app-config branch April 23, 2021 10:58
@cnobile2012
Copy link

It looks like this is still an issue with the latest version of debug_toolbar.
This is the init.py

$ cat __init__.py 
__all__ = ["VERSION"]


# Do not use pkg_resources to find the version but set it here directly!
# see issue #1446
VERSION = "3.2.1"

# Code that discovers files or modules in INSTALLED_APPS imports this module.

urls = "debug_toolbar.toolbar", "djdt"

default_app_config = "debug_toolbar.apps.DebugToolbarConfig"

The last line should probably be:

if django.VERSION < (3, 2):
    default_app_config = 'rest_framework.apps.RestFrameworkConfig'

@francoisfreitag
Copy link
Contributor Author

The last release was Apr 14th, this PR was merged on Apr 23rd.
This code will appear in the next release.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants