-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove codecov, solely use coverage. #1542
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove codecov, solely use coverage. #1542
Conversation
CodeCov has become a bit flaky in their evaluation of code coverage. Using GitHub actions, we can utilize coverage to combine multiple reports. Thanks to Hynek Schlawack for the approach. https://hynek.me/articles/ditch-codecov-python/ Remove .coveragerc file in favor of configuration in setup.cfg Also applies coverage's parallel mode always.
@matthiask what do you think about dropping codecov? It's probably possible to get the github actions to create/update a comment on the PR with the report generated. I'm a bit unsure of all this, but I do know we've had a few PRs fail CI due to codecov saying it didn't cover everything. Additionally, we'd probably need to lower the failure percentage and/or cover existing code paths. |
I read the post by Hynek too. It makes a lot of sense to me. Thank you! |
how is the report looks like? |
@auvipy in this implementation you'd have to click on the "Check coverage" action's details link: https://github.com/jazzband/django-debug-toolbar/runs/4514568613?check_suite_focus=true It contains a table that looks like the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it woul be better start using a pyproject.toml
to store configurations.
Co-authored-by: Paolo Melchiorre <paolo@melchiorre.org>
Co-authored-by: Paolo Melchiorre <paolo@melchiorre.org>
Co-authored-by: Paolo Melchiorre <paolo@melchiorre.org>
Co-authored-by: Paolo Melchiorre <paolo@melchiorre.org>
I quite agree with you, but may be in another PR |
Any qualms with me setting the failure percentage to 89%? |
I think that's fine. Maybe you could insert a |
I agree with that. We can also define a coverage goal fro the next release (e.g. 90%) |
@pauloxnet can you confirm that all of your concerns with the PR were addressed? I'll squash and merge our commits after I get that green checkmark. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything ok for me.
I noticed only now that in this PR we forgot to update the coverage badge in the README. |
Since django-commons#1542, coverage creates parallel files, with names like `.coverage.<hostname>.<pid>.<someothernumber>`, which need ignoring too.
Since #1542, coverage creates parallel files, with names like `.coverage.<hostname>.<pid>.<someothernumber>`, which need ignoring too.
CodeCov has become a bit flaky in their evaluation of code coverage.
Using GitHub actions, we can utilize coverage to combine multiple reports.
Thanks to Hynek Schlawack for the approach.
https://hynek.me/articles/ditch-codecov-python/