Skip to content

Drop support for Django 2.2 #1551

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Conversation

hramezani
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #1551 (246fdee) into main (1964826) will increase coverage by 0.75%.
The diff coverage is 66.66%.

❗ Current head 246fdee differs from pull request most recent head 8acfbe5. Consider uploading reports for the commit 8acfbe5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1551      +/-   ##
==========================================
+ Coverage   85.87%   86.62%   +0.75%     
==========================================
  Files          36       36              
  Lines        1883     1862      -21     
  Branches      310      303       -7     
==========================================
- Hits         1617     1613       -4     
+ Misses        187      175      -12     
+ Partials       79       74       -5     
Impacted Files Coverage Δ
debug_toolbar/__init__.py 100.00% <ø> (+28.57%) ⬆️
debug_toolbar/panels/cache.py 78.66% <61.11%> (+6.10%) ⬆️
debug_toolbar/management/commands/debugsqlshell.py 100.00% <100.00%> (ø)
debug_toolbar/panels/settings.py 100.00% <100.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1964826...8acfbe5. Read the comment docs.

@matthiask
Copy link
Member

@hramezani Please try again, I pushed the wrong branch but I've reverted the change.

Copy link
Member

@matthiask matthiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good already. There are still a few django.VERSION branches around which could be dropped as well, but we don't have to clean up everything at once.

@hramezani
Copy link
Contributor Author

@matthiask I will find them and remove them

@matthiask
Copy link
Member

I added a commit on top which installs gdal-bin before running tests. Now it's all green.

@matthiask matthiask merged commit 8acfbe5 into django-commons:main Dec 16, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants