Async compatible StaticFilesPanel
#1983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ready monkey patching
|
I think it still need those integration type tests. on it. |
|
I have added one new test that practically tests panel's async compatibility which it failed before. We can test the concurrent capabilities in integration testing. |
tim-schilling
approved these changes
Aug 20, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses signals for automatic instrumentation of
StaticFilesPaneland trigger recording mechanis.and 2
ContextVarone for storing staticfiles particular to that request context and another for to identify signal for each request context.Checklist:
docs/changes.rst.