Enhance process_request to handle non-numeric content length #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ch00k
reviewed
Sep 29, 2024
| content_length = int(request.META.get("CONTENT_LENGTH") or 0) | ||
| content_length = 0 | ||
| raw_content_length = request.META.get("CONTENT_LENGTH", "") | ||
| if raw_content_length.isdigit(): |
There was a problem hiding this comment.
I wouldn't bother with the isdigit() call, but use try..except ValueError, TypeError instead: isdigit would return True for digits that int() would still fail to convert, for example ₂. It is unlikely that this would happen in real world, but it is theoretically possible.
I would also add a unit test for this change.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered errors with non-numeric content lengths. Exceptions are threw with 500. It's better to handle ill-formatted HTTP headers.