Skip to content

Use assert when checking for reserved field names #1025

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Dec 9, 2021

Follow up of #992

Description of the Change

This check is for development purposes to verify that the source code is well configured but not needed during production. Therefore a assert is more appropriate.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

This check is for development purposes to verify that the source code
is well configured but not needed during production. Therefore a assert
is more appropriate.
@sliverc sliverc requested a review from n2ygk December 9, 2021 18:06
@sliverc sliverc mentioned this pull request Dec 9, 2021
5 tasks
@n2ygk n2ygk merged commit 28e553a into django-json-api:master Dec 9, 2021
@sliverc sliverc deleted the assert_insteadof_attr branch December 9, 2021 19:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants