Skip to content

Re-enabled overwriting of URL field #1237

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Jun 23, 2024

Addresses #1233

Description of the Change

URL_FIELD_NAME is usually used as self-link in links. However, the field name should be allowed to be overwritten as long as the field type is not HyperlinkedIdentifyField which HyperlinkedModelSerializer uses.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

URL_FIELD_NAME is usually used as self-link in links.
However it should be allowed to be overwritten as long
as not HyperlinkedIdentifyField has been used.
@sliverc sliverc requested a review from n2ygk June 23, 2024 18:54
@n2ygk n2ygk merged commit 53469f3 into django-json-api:main Jun 24, 2024
11 checks passed
@sliverc sliverc deleted the allow_url branch June 24, 2024 21:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants