ValueError: int is not allowed for map key when using msgpack 1.0.0 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
"ValueError: int is not allowed for map key" will be raised when using msgpack 1.0.0 for some messages
Explanation:
This is to the fact that they changed their default setting for msgpack.unpackb see: msgpack/msgpack-python#411 which they also discuss as major braking points in https://github.com/msgpack/msgpack-python#major-breaking-changes-in-msgpack-10
Solution:
adding strict_map_key=False as argument whenever msgpack.unpackb or msgpack.loads is called
so mainly solution I take from pupil-labs/pupil#1830