Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

support msgpack.packb kwargs #380

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mpnowacki-reef
Copy link

The main reason for submitting this PR is to give users the ability to subclass RedisChannelLayer and do sth like:

def default(value):
    if isinstance(value, enum.Enum):
        return value.value
    return value


class ECRedisChannelLayer(RedisChannelLayer):
    """EC stands for "enum-compatible" """
    def _packing_kwargs(self, message):
        return {**super()._packing_kwargs, 'default': default}

Verified

This commit was signed with the committer’s verified signature.
elpiel Lachezar Lechev
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case showing the usage here?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants