-
-
Notifications
You must be signed in to change notification settings - Fork 997
Fixed styling of buttons leaking to Debug Toolbar #2041
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
We have something like a CSS reset in the toolbar repository near the top of toolbar.css. It doesn't reset height though, changing this might also help and would probably be a better fix for other projects too. I think this should really be fixed in the toolbar and not in individual projects using the toolbar. |
I agree that this should probably be fixed upstream. For what it's worth, I don't think CSS related to a development dependency should leak into the production file. |
Hmm, that's an excellent point 🤔 |
Not that I know of, but I can try to do some digging soon if you're interested in that approach. |
It would be great if someone found the time to test this alternative approach to fixing this! |
@matthiask 's PR fixes the issue without us having to introduce a dev-only CSS rule in our production file, so I'm going to close this PR in favor of that. |
Great, thanks! |
This isn't a 100% fix, but it takes care of the buttons at least. I guess we could go and spread some
:not(#djDebug *)
all over our CSS, but I'm not sure that's a really sustainable solution (plus it might have a performance cost that could add up).Screenshots:
Before
After